Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add back metric integration testing to the otelgocql/test package #2962

Merged
merged 6 commits into from
Dec 8, 2022
Merged

Add back metric integration testing to the otelgocql/test package #2962

merged 6 commits into from
Dec 8, 2022

Conversation

MrAlias
Copy link
Contributor

@MrAlias MrAlias commented Nov 1, 2022

Fix #2761

@MrAlias MrAlias added the Skip Changelog Allow PR to succeed without requiring an addition to the CHANGELOG label Nov 1, 2022
@MrAlias MrAlias added this to the v0.36.5 milestone Nov 1, 2022
@codecov
Copy link

codecov bot commented Nov 1, 2022 •
edited
Loading

Codecov Report

Merging #2962 (1e3ec88) into main (3b2c5ba) will increase coverage by 3.0%.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##            main   #2962     +/-   ##
=======================================
+ Coverage   69.0%   72.0%   +3.0%     
=======================================
  Files        147     149      +2     
  Lines       6875    6921     +46     
=======================================
+ Hits        4748    4989    +241     
+ Misses      2009    1801    -208     
- Partials     118     131     +13
Impacted Files Coverage Δ
.../github.com/gocql/gocql/otelgocql/internal/cass.go 95.1% <0.0%> (ø)
...n/github.com/gocql/gocql/otelgocql/test/version.go 0.0% <0.0%> (ø)
...ion/github.com/gocql/gocql/otelgocql/instrument.go 62.5% <0.0%> (+62.5%) ⬆️
...ntation/github.com/gocql/gocql/otelgocql/config.go 67.3% <0.0%> (+67.3%) ⬆️
...ation/github.com/gocql/gocql/otelgocql/observer.go 75.1% <0.0%> (+75.1%) ⬆️
...entation/github.com/gocql/gocql/otelgocql/gocql.go 100.0% <0.0%> (+100.0%) ⬆️
...tation/github.com/gocql/gocql/otelgocql/version.go 100.0% <0.0%> (+100.0%) ⬆️

@MrAlias MrAlias mentioned this pull request Nov 1, 2022
Open
@MrAlias MrAlias modified the milestones: v0.36.5, v0.37.1 Dec 6, 2022
@MrAlias MrAlias merged commit a556b5a into open-telemetry:main Dec 8, 2022
@MrAlias MrAlias deleted the fix-2761 branch December 8, 2022 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dashpole dashpole dashpole approved these changes

@MadVikingGod MadVikingGod MadVikingGod approved these changes

@jmacd jmacd Awaiting requested review from jmacd

@Aneurysm9 Aneurysm9 Awaiting requested review from Aneurysm9

@evantorrie evantorrie Awaiting requested review from evantorrie

@XSAM XSAM Awaiting requested review from XSAM

@pellared pellared Awaiting requested review from pellared

@hanyuancheung hanyuancheung Awaiting requested review from hanyuancheung

@dmathieu dmathieu Awaiting requested review from dmathieu

Assignees
No one assigned
Labels
instrumentation: otelgocql Skip Changelog Allow PR to succeed without requiring an addition to the CHANGELOG
Projects
No open projects
Go: Metric SDK (Beta)
Status: Done
Milestone
v0.38.0
Development

Successfully merging this pull request may close these issues.

Add back metric integration testing to the otelgocql/test package
3 participants
@MrAlias @dashpole @MadVikingGod